Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
simonfaltum
left a comment
There was a problem hiding this comment.
Post-generate manual fixes are annotated inline below. Everything else is output from make generate + python make codegen + refschema golden update.
| AutoscalingLimitMinCu: 0, | ||
| Disabled: false, | ||
| EndpointType: "", | ||
| Group: nil, |
There was a problem hiding this comment.
Manual fix: New Group field added in SDK v0.111.0 for postgres.EndpointSpec. Added here to satisfy exhaustruct linter — the struct literal must initialize all fields.
| ProjectId: config.ProjectId, | ||
| Project: postgres.Project{ | ||
| Spec: &config.ProjectSpec, | ||
| Spec: &config.ProjectSpec, |
There was a problem hiding this comment.
Manual fix: New InitialEndpointSpec field added in SDK v0.111.0 for postgres.Project. Set to nil in both DoCreate and DoUpdate to satisfy exhaustruct linter.
| @@ -90,7 +91,8 @@ func (r *ResourcePostgresProject) DoUpdate(ctx context.Context, id string, confi | |||
|
|
|||
| waiter, err := r.client.Postgres.UpdateProject(ctx, postgres.UpdateProjectRequest{ | |||
| Project: postgres.Project{ | |||
There was a problem hiding this comment.
Manual fix: Same InitialEndpointSpec exhaustruct fix as above, this time in DoUpdate.
| "disabled", | ||
| "endpoint_id", | ||
| "endpoint_type", | ||
| "group", |
There was a problem hiding this comment.
Manual fix: Added group to knownMissingInRemoteType for postgres_endpoints — mirrors the new Group field in EndpointSpec that isn't present in the remote type mapping.
| "description": |- | ||
| PLACEHOLDER | ||
| github.com/databricks/databricks-sdk-go/service/apps.AppResource: | ||
| "app": |
There was a problem hiding this comment.
Manual fix: Added app PLACEHOLDER entry for the new AppResource.App field introduced in this SDK version. Needed because annotations.yml generation added it but the overrides file needs a corresponding entry.
|
Commit: ad69385
15 interesting tests: 7 KNOWN, 7 SKIP, 1 RECOVERED
Top 20 slowest tests (at least 2 minutes):
|
The new `endpoints` command under account provisioning was added by the SDK bump generation but the acceptance test output wasn't regenerated.
Changes
github.com/databricks/databricks-sdk-gofromv0.110.0tov0.111.0and bump.codegen/_openapi_shato the matching OpenAPI commit (d91ff2db7c9265e784ceac0de2059f3e5fada8c5).make generate) and sync generated outputs across commands, schemas, direct resources, and Python bundle bindings.Groupfield topostgres.EndpointSpecexhaustruct inpostgres_endpoint.go.InitialEndpointSpecfield topostgres.Projectexhaustruct inpostgres_project.go.ExternalLocationgrants/lifecycle entries fromannotations_openapi_overrides.yml(already present inannotations.yml).grouptoknownMissingInRemoteTypeforpostgres_endpointsintype_test.go.Why
Keep CLI generated surfaces aligned with the latest Go SDK/OpenAPI changes and ensure generation remains green on lint/tests.
Tests
./tools/golangci-lint run(0 issues)go test ./internal/build ./bundle/internal/schema ./bundle/direct/dresources ./bundle/config/resources -count=1go test ./acceptance -run '^TestAccept/bundle/refschema$' -update -timeout=30m(run twice)go test ./acceptance -run '^TestAccept/bundle/refschema$' -timeout=30mpushd python && make codegen && popdmake checks